bgpd: Make suppress-fib-pending clear peering#14982
Merged
riw777 merged 1 commit intoFRRouting:masterfrom Dec 12, 2023
Merged
Conversation
Member
Author
|
@Mergifyio backport stable/9.0 stable/9.1 stable/8.5 |
✅ Backports have been createdDetails
|
ton31337
reviewed
Dec 11, 2023
Member
ton31337
left a comment
There was a problem hiding this comment.
A couple of nits from my side (more like cosmetic, but yeah).
bgpd/bgp_fsm.c
Outdated
| "Reached received prefix count", | ||
| "Socket Error", | ||
| "Admin. shutdown (RTT)", | ||
| "Suppress Fib Turned on or Off", |
Member
There was a problem hiding this comment.
nit: Just to be consistent: on or off (lowercase, but not mixed).
bgpd/bgpd.c
Outdated
| if (bgp_suppress_fib_count == 0) | ||
| send_msg = true; | ||
| bgp_suppress_fib_count++; | ||
|
|
| #define PEER_DOWN_PFX_COUNT 33U /* Reached received prefix count */ | ||
| #define PEER_DOWN_SOCKET_ERROR 34U /* Some socket error happened */ | ||
| #define PEER_DOWN_RTT_SHUTDOWN 35U /* Automatically shutdown due to RTT */ | ||
| #define PEER_DOWN_SUPPRESS_FIB_PENDING 36U /* Suppress fib pending changed */ |
Member
There was a problem hiding this comment.
Seems we have a bit unaligned here.
Member
Author
There was a problem hiding this comment.
this is what clang-format has decided on. I have no idea why it's not aligned
When a peer has come up and already started installing routes into the rib and `suppress-fib-pending` is either turned on or off. BGP is left with some routes that may need to be withdrawn from peers and routes that it does not know the status of. Clear the BGP peers for the interesting parties and let's let us come up to speed as needed. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
8be2099 to
bdb5ae8
Compare
This was referenced Dec 12, 2023
donaldsharp
added a commit
that referenced
this pull request
Dec 12, 2023
bgpd: Make `suppress-fib-pending` clear peering (backport #14982)
donaldsharp
added a commit
that referenced
this pull request
Dec 12, 2023
bgpd: Make `suppress-fib-pending` clear peering (backport #14982)
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a peer has come up and already started installing routes into the rib and
suppress-fib-pendingis either turned on or off. BGP is left with some routes that may need to be withdrawn from peers and routes that it does not know the status of. Clear the BGP peers for the interesting parties and let's let us comeup to speed as needed.