bgpd: Allow network XXX to work with bgp suppress-fib-pending#12113
Merged
ton31337 merged 1 commit intoFRRouting:masterfrom Oct 14, 2022
Merged
bgpd: Allow network XXX to work with bgp suppress-fib-pending#12113ton31337 merged 1 commit intoFRRouting:masterfrom
network XXX to work with bgp suppress-fib-pending#12113ton31337 merged 1 commit intoFRRouting:masterfrom
Conversation
When bgp is using `bgp suppress-fib-pending` and the end operator is using network statements, bgp was not sending the network'ed prefix'es to it's peers. Fix this. Also update the test cases for bgp_suppress_fib to test this new corner case( I am sure that there are going to be others that will need to be added ). Fixes: FRRouting#12112 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Member
Author
|
@Mergifyio backport dev/8.4 |
Member
Author
|
@Mergifyio backport stable/8.3 |
✅ Backports have been createdDetails
|
Member
Author
|
@Mergifyio backport stable/8.2 |
✅ Backports have been createdDetails
|
✅ Backports have been createdDetails
|
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 7: Incomplete(check logs for details)Successful on other platforms/tests
|
ton31337
reviewed
Oct 13, 2022
Member
Author
|
ci:rerun ci has gone belly up again |
Collaborator
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7885/ This is a comment from an automated CI system. |
This was referenced Oct 14, 2022
ton31337
added a commit
that referenced
this pull request
Oct 14, 2022
bgpd: Allow `network XXX` to work with bgp suppress-fib-pending (backport #12113)
ton31337
added a commit
that referenced
this pull request
Oct 14, 2022
bgpd: Allow `network XXX` to work with bgp suppress-fib-pending (backport #12113)
donaldsharp
added a commit
that referenced
this pull request
Oct 14, 2022
bgpd: Allow `network XXX` to work with bgp suppress-fib-pending (backport #12113)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bgp is using
bgp suppress-fib-pendingand the end operator is using network statements, bgp was not sending the network'ed prefix'es to it's peers. Fix this.Also update the test cases for bgp_suppress_fib to test this new corner case( I am sure that there are going to be others that will need to be added ).
Fixes: #12112
Signed-off-by: Donald Sharp sharpd@nvidia.com