Set power correctly when changing RF band #3216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures that the power is correct for the selected band
JyeSmith
approved these changes
May 13, 2025
Member
|
Nice catch. Looks like only the PAs were configured, but not the power output after the band change. |
mha1
approved these changes
May 13, 2025
frank26080115
pushed a commit
to frank26080115/ExpressLRS
that referenced
this pull request
Jul 2, 2025
this ensures that the power is correct for the selected band
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing band the telemetry output power on an RX was not set correctly for the new RF path.
I noticed when doing testing on an LR1121 RX that if I was on 2.4GHz and set the telemetry power to 10mW, then switched to 915MHz the power would jump up to the 'default' or previously set level on that band.