Allow LR1121 single RF path #2998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdware-with-only-a-single-LR1121
76f85da to
8e3181b
Compare
8e3181b to
5a983ba
Compare
JyeSmith
reviewed
Oct 21, 2024
Also check the supported rate in the SetRFLinkRate and bail early if not supported
SetRFLinkRate() is now set correctly with the current rate and the initial frequency configured.
Member
|
Looks good. But I did have to move a rate check out of SetRFLinkRate(). Bombing out there would leave the rx on a random frequency and not ready to listen for a sync packet to reconnect. Now when you set the tx to a forbidden mode the rx will be configured correctly to reconnect when the tx changes back to the original mode. |
Collaborator
Author
|
Retested with your changes and look good. |
JyeSmith
approved these changes
Oct 22, 2024
config.GetRate() can return a disabled rf mode, which will get set on uartconnected.
Member
|
Added an extra check to the menu. Plus a check to catch a default tx config with a forbidden mode saved. Tested on the dev board.
|
wvarty
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends upon #2977 to allow LR1121 targets to define a single RF path.
i.e. "Power Values" empty is no 900MHz path, "Power Values Dual" empty is no 2.4GHz path.