Remove Dual Band option from hardware with only a single LR1121 #2977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdware-with-only-a-single-LR1121
pkendall64
approved these changes
Oct 17, 2024
Member
Author
|
Close because #2998 has this covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the GemX rates from hardware with only a single LR1121. We cant have a users thinking hardware is operating in GemX modes, when in fact only the SubGHz band is used.
The Rx will cycle past these modes on boot. BUT, if a users connects to a single LR1121 Rx with a GemX Tx they can change to a GemX mode and the Rx will follow. I think it will be better to maintain a link than drop it, but I can be easily persuaded if others dont agree.
Currently I dont know how to handle this with the display and thats a future problem when hardware becomes available.