Skip to content

Closes #947 Update finish import script #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelStritt merged 2 commits into from
Dec 1, 2021
Merged

Closes #947 Update finish import script #961

MichaelStritt merged 2 commits into from
Dec 1, 2021

Conversation

@MichaelStritt
Copy link
Contributor

@MichaelStritt MichaelStritt commented Dec 1, 2021

Linked issue

Check out #947

@MichaelStritt MichaelStritt added the optimization Ensure that code runs faster with unchanged functionality label Dec 1, 2021
@MichaelStritt MichaelStritt self-assigned this Dec 1, 2021
@MichaelStritt MichaelStritt linked an issue Dec 1, 2021 that may be closed by this pull request
xASL_imp_FinishImport violates modularity #947
Closed
HenkMutsaerts
HenkMutsaerts approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@MichaelStritt MichaelStritt merged commit 9d457c1 into develop Dec 1, 2021
@MichaelStritt MichaelStritt deleted the opt-#947_FinishImport branch December 1, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenkMutsaerts HenkMutsaerts HenkMutsaerts approved these changes

@jan-petr jan-petr Awaiting requested review from jan-petr

Assignees

@MichaelStritt MichaelStritt

Labels

optimization Ensure that code runs faster with unchanged functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xASL_imp_FinishImport violates modularity

3 participants

@MichaelStritt @HenkMutsaerts