Skip to content

xASL_imp_FinishImport violates modularity #947

@HenkMutsaerts

Description

@HenkMutsaerts

Description

We strive towards modularity, where submodules are iterated and take care over their own "householding". It is important that the user can always combine these modules to its own liking, which works with the lock files. if a lock file doesn't exist for a current iteration of a current module, the submodule will start with householding (deleting previous derivatives for this iteration, etc), then running all submodules/wrappers, and then doing the final householding (deleting temporary files etc).

So in other words, all general householding functions (either initializing or "finish" should do general stuff only.

Requirements

So the contents of xASL_imp_FinishImport should be distributed across their actual (sub-)modules.

How to test

If a user runs dcm2nii and nii2BIDS, the derivatives folder should be untouched, unchecked, no warning or printing given on the screen. All the touching, checking, printing, warning of derivatives should be done in BIDS2Legacy.

Likewise, if a user runs BIDS2Legacy, the sourcedata and temp folders should be untouched, unchecked, and no warning or printing on this.

Release notes

No need for release notes, this is just improving good coding practice.

Metadata

Metadata

Assignees

Labels

optimizationEnsure that code runs faster with unchanged functionality

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions