Skip to content

Conversation

@MichaelStritt
Copy link
Contributor

Linked issue

Check out the detailed explanations in #632

@MichaelStritt MichaelStritt added feature New feature, enhancement or request minor improvements Fixes that don't change main pipeline functionality labels Jun 9, 2021
@MichaelStritt MichaelStritt self-assigned this Jun 9, 2021
@MichaelStritt MichaelStritt linked an issue Jun 9, 2021 that may be closed by this pull request
@jan-petr jan-petr requested review from jan-petr and removed request for BeatrizPadrela June 10, 2021 16:05
Copy link
Contributor

@jan-petr jan-petr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. But I didn't like that it printed the RMSE also within flavor test when there was no difference. So I have activated that only when detailedOutput is on. Because I like to check directly on the screen if the import went fine and there are no errors - without going to the tsv or xls. But if you still want to have that - no problem ;)

Otherwise - if you agree with the change, we can merge...

@MichaelStritt
Copy link
Contributor Author

Nice change. But I didn't like that it printed the RMSE also within flavor test when there was no difference. So I have activated that only when detailedOutput is on. Because I like to check directly on the screen if the import went fine and there are no errors - without going to the tsv or xls. But if you still want to have that - no problem ;)

Otherwise - if you agree with the change, we can merge...

No, that's perfect 👍
I just wanted to put it in a separate script because I saw that @BeatrizPadrela recently needed a script which basically does exactly this :)

@MichaelStritt MichaelStritt force-pushed the feature-#632_NiftiComparison branch from 74cddb0 to 9398625 Compare June 10, 2021 17:46
@MichaelStritt MichaelStritt merged commit 9398625 into develop Jun 10, 2021
@MichaelStritt MichaelStritt deleted the feature-#632_NiftiComparison branch June 10, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature, enhancement or request minor improvements Fixes that don't change main pipeline functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve untouched nifti comparison

3 participants