-
Notifications
You must be signed in to change notification settings - Fork 13
Bug #1167 nii2 bids new #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug #1167 nii2 bids new #1179
Conversation
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Also, where did my edits go? (they were about being flexible with the NIfTI naming, using regular expressions, when doing NII2BIDS)
|
Last thing - regarding adding similar warnings as you did in the alternative commit: There is no need to add those because they are already there. You didn't add a new warning, you have simply taken an existing one and moved it to a different location. So that warning is still there in |
BeatrizPadrela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely
That's not what I meant. In the code that Bea and me changed, you want a warning if an incorrect filename was detected (which you said is impossible, but it will still help us). And to improve the warnings there, to be a bit more explanatory. |
You mean, not a warning that the file was missing, but a warning that a similar filename was detected, but not according to what was expected? |
|
Now the warnings are similar to as they were in your commits. |
HenkMutsaerts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Minor cosmetics, we should always add a space ' ' after a comma in Matlab (I learned from somebody :) and you put ( ) that are not required in Matlab.
Linked issue
Closes #1167