Skip to content

Conversation

@jan-petr
Copy link
Contributor

Linked issue

#823. Agreed with all comments. New Development folder under functions will be created in an issue #1073 - it needs a new issues, because we also need to adapt the documentation and folder initialization etc.

@jan-petr jan-petr self-assigned this Jan 31, 2022
@jan-petr jan-petr linked an issue Jan 31, 2022 that may be closed by this pull request
9 tasks
Copy link
Member

@HenkMutsaerts HenkMutsaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should give the good example to the kids, "clean develop folder" is not really a specific commit title. "Clean develop: delete study config files" would be better:)

I don't understand why we make a list in a single issue and then only do 1 item from this list ;)

The docu functionality needs to be improved anyway, as we discussed this morning, so why not moving the other development files to the new folder in this issue, and updating the docu files in this issue as well? Splitting issues for real functional differences is good but spreading too thin in this case imho.

BTW: we should adapt the docu crawling, that it doesn't crawl across a fixed number of folders but across all folders inside /Functions, then we don't have to change the docu crawler function for each time we add a new folder to /Functions.

@MichaelStritt MichaelStritt changed the title Optimize #823 development cleaning Closes #823 development cleaning Feb 1, 2022
@MichaelStritt MichaelStritt added the feature New feature, enhancement or request label Feb 1, 2022
@jan-petr
Copy link
Contributor Author

jan-petr commented Feb 2, 2022

The list was to start the discussion - so a part was done (several things), a part will be done in a different issue, part I found out doesn't need to be done.

@ExploreASL ExploreASL deleted a comment from MichaelStritt Feb 7, 2022
@jan-petr jan-petr force-pushed the optimize-#823_DevelopmentCleaning branch from 7607878 to c9f8742 Compare February 8, 2022 18:17
@jan-petr jan-petr merged commit c9f8742 into develop Feb 8, 2022
@jan-petr jan-petr deleted the optimize-#823_DevelopmentCleaning branch February 8, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature, enhancement or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean development folder

4 participants