-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
Labels
featureNew feature, enhancement or requestNew feature, enhancement or request
Milestone
Description
Description
Clean the development folder
Requirements
-
Siemens_ConcatenateNIfTI.mwe probably don't need this one anymore? @jan-petr
-> HM says: this was a function that I created in the past, I think you also wrote something like this
-> Jan: Yes, we have concatenation as part of the import, and more robust than this version. - Can be moved to
CustomScript/ExploreASLLegacy:BIDS_createTemplatesImportConfig.m,xASL_im_TestDummyNIfTIOrientation.m
-> HM says: good idea - Old import can be moved to
CustomScript/ExploreASLLegacy:xASL_ImportFull.m
-> HM says: yes - Config files for old studies are moved to
CustomScript/ExploreASLLegacy
-> HM says: why not a separate folderCustomScript/StudyConfigs - Can be moved to
CustomScript/ExploreASLLegacy:xASL_io_ConvertNiiGz2Mat.m.? Do you agree? @MichaelStritt
-> HM says: no this function is needed for the creation of new atlases.
-> Agree. New category of development functions #1073 - Can be moved to
CustomScript/ExploreASLLegacy:QualityControl/xASL_qc_TestExploreASL_HM.m
-> HM says: Yes good idea - Can be moved to
CustomScript/ExploreASLLegacy:xASL_spm_jobman.m? JAN: I have checked it and it is not used anywhere, so lets move it. Do you agree? @HenkMutsaerts
-> HM says: I think I wrote this for running spm jobman deployed, but if we don't use it then it can go toCustomScript/ExploreASLLegacyindeed -
UnitTest_xASL_io_DcmtkRead.mI wrote this for Jan to testxASL_io_DcmtkRead, but he didn't check it out. Can we delete it? JAN: IMHO, lets delete this as we use DcmtkRead actively in import and that's a super robust test on 50+ flavors that it works.
-> HM says: this function iterates across multiple DICOMs and their fields and compares them between Matlab'sdicominfoandxASL_io_DcmtkRead -
/Functions/Administration/xASL_adm_DocCrawler.m->/Functions/Development/xASL_dev_DocCrawler.m
/Functions/Administration/xASL_adm_DocInitialize.m->/Functions/Development/ xASL_dev_DocInitialize.m
(and other docu functions)
-> Agree. New category of development functions #1073
-> HM says: As discussed, we create a new folder /Functions/Development, where functions live with the prefix xASL_dev_*, e.g. xASL_dev_ConvertNiiGz2Mat.m. These are functions that aren't used in the pipeline and that developers use to improve the pipeline.
-> Agree. #1073
Release notes
Cleaned unused functions in the Development folder.
Metadata
Metadata
Assignees
Labels
featureNew feature, enhancement or requestNew feature, enhancement or request