Skip to content

Make keyboard-interactive auth URLs clickable#11327

Merged
Eugeny merged 1 commit into
Eugeny:masterfrom
puneetdixit200:fix-8576-keyboard-interactive-links
Jun 9, 2026
Merged

Make keyboard-interactive auth URLs clickable#11327
Eugeny merged 1 commit into
Eugeny:masterfrom
puneetdixit200:fix-8576-keyboard-interactive-links

Conversation

@puneetdixit200

Copy link
Copy Markdown
Contributor

Summary

  • split keyboard-interactive prompt text into safe text/link parts
  • make validated http/https URLs clickable without binding remote prompt HTML
  • open prompt links through the existing platform external-open service

Fixes #8576.

Verification

  • ./node_modules/.bin/eslint --ext ts tabby-ssh/src/components/keyboardInteractiveAuthPanel.component.ts
  • ./node_modules/.bin/pug-lint --config /tmp/tabby-pug-lint-empty.json tabby-ssh/src/components/keyboardInteractiveAuthPanel.component.pug
  • ./node_modules/.bin/webpack --config tabby-ssh/webpack.config.mjs
  • git diff --check

@Eugeny

Eugeny commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Thank you! @all-contributors add @puneetdixit200 for code

@Eugeny Eugeny merged commit f49ca51 into Eugeny:master Jun 9, 2026
10 checks passed
@allcontributors

Copy link
Copy Markdown
Contributor

@Eugeny

I've put up a pull request to add @puneetdixit200! 🎉

robertpelloni added a commit to robertpelloni/tabby that referenced this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The link in the two-factor (Keyboard-interactive) auth is not clickable.

3 participants