This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Merged
Conversation
Member
|
@jwasil only thing holding me back from merging is that this feels like treating the symptom and not the problem. I think the root cause is upstream in the JSAPI, so I say we leave this open until 4.0 final is released and see if it gets solved there. If not, we can merge this as a band aid. |
Contributor
Author
|
Agreed! |
Member
|
just changed my mind. just left a note to selves to reverse this later #235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #226; added autoscroll property to ng-view to scroll to the top on route change
@tomwayson please check it out. No rush. I think it is a decent fix if on a desktop browser, but when it is responsive (e.g. mobile device) the scroll to the top behavior might be jarring.
As an alternative, I played around with the following during the route change listener (see leftNavController.js) to actually scroll to, say an
<h2 id="xyzID">element in an example page, but I still saw the JSAPI flickering/flashing somtimes.