Increase Attestation Proof Generation Timeout#356
Increase Attestation Proof Generation Timeout#356jjeangal merged 2 commits intocelo-integration-rebase-14.2from
Conversation
Summary of ChangesHello @jjeangal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an operational stability concern by increasing the timeout duration for generating zero-knowledge proofs. The adjustment aims to mitigate instances where the proof generation process exceeds the previously allotted time, thereby improving the reliability of the attestation mechanism. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request increases the ZK proof generation timeout from 2 to 3 minutes to mitigate observed timeouts during the attestation process. The change is a correct operational fix for the reported issue. My feedback suggests a refactoring to improve maintainability by avoiding hardcoded durations for network operations.
op-batcher/batcher/espresso.go
Outdated
| request.Header.Set("Content-Type", "application/octet-stream") | ||
| client := http.Client{ | ||
| Timeout: 2 * time.Minute, | ||
| Timeout: 3 * time.Minute, |
There was a problem hiding this comment.
Hardcoding the timeout duration directly in the function body makes it difficult to adjust for different environments (e.g., slower development networks vs. production) without a recompile. Consider moving this value to a configuration parameter in the BatcherConfig struct or at least defining it as a constant at the top of the file. This is especially relevant for long-running operations like ZK proof generation which may have varying performance characteristics across different infrastructure setups.
op-batcher/batcher/espresso.go
Outdated
| request.Header.Set("Content-Type", "application/octet-stream") | ||
| client := http.Client{ | ||
| Timeout: 2 * time.Minute, | ||
| Timeout: 3 * time.Minute, |
There was a problem hiding this comment.
increase the time more or it will time out more
* increase proof generation timeout * increase to 5 minutes
This PR
Simply increases the
GenerateZKProoftimeout from 2 minutes to 3 minutes as it has timed out a few times already.