AF1.1 Fix changing loop iteratee during iteration#212
Merged
shenkeyao merged 1 commit intocelo-integration-rebase-13.2from Aug 22, 2025
Merged
AF1.1 Fix changing loop iteratee during iteration#212shenkeyao merged 1 commit intocelo-integration-rebase-13.2from
shenkeyao merged 1 commit intocelo-integration-rebase-13.2from
Conversation
Collaborator
|
Isn't this supposed to be safe to do in Go? https://go.dev/ref/spec#For_range
|
Member
|
The relevant section @QuentinI is referencing:
It is safe to remove entries that have not yet been encountered. That being said, I would likely still prefer to not take advantage of such a feature, and be consistent with other languages in this case. |
Ayiga
approved these changes
Aug 22, 2025
QuentinI
approved these changes
Aug 22, 2025
dailinsubjam
pushed a commit
that referenced
this pull request
Oct 4, 2025
dailinsubjam
pushed a commit
that referenced
this pull request
Oct 7, 2025
shenkeyao
added a commit
that referenced
this pull request
Jan 15, 2026
shenkeyao
added a commit
that referenced
this pull request
Feb 2, 2026
shenkeyao
added a commit
that referenced
this pull request
Feb 10, 2026
shenkeyao
added a commit
that referenced
this pull request
Feb 12, 2026
QuentinI
pushed a commit
that referenced
this pull request
Feb 20, 2026
shenkeyao
added a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://app.asana.com/1/1208976916964769/project/1209392461754458/task/1211106994726375?focus=true.
This PR: