Interp2 by wsmoses · Pull Request #365 · EnzymeAD/Reactant.jl

wsmoses · 2024-12-11T18:29:45Z

No description provided.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 490 in f4349a9

src/TracedRNumber.jl

src/TracedUtils.jl

lib/ReactantCore/src/ReactantCore.jl

src/linear_algebra.jl

ext/ReactantNNlibExt.jl

src/Tracing.jl

src/linear_algebra.jl

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Lines 510 to 513 in 70c3951

    
           push!( 
        
               overdubbed_code, 
        
               Core.ReturnNode(Core.SSAValue(length(overdubbed_code))) 
        
           )

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 526 in 70c3951

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 436 in f839a0b

iter_args = min(n_actual_args, n_method_args-1)

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 438 in f839a0b

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 448 in f839a0b

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 450 in f839a0b

    
           push!(overdubbed_code, Expr(:call, safe_print, "fn arg["*string(length(fn_args))*"]", fn_args[end]))

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 455 in f839a0b

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Lines 470 to 472 in f839a0b

    
           push!( 
        
               overdubbed_code, trailing_arguments 
        
           )

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 476 in f839a0b

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 478 in f839a0b

    
           push!(overdubbed_code, Expr(:call, safe_print, "fn arg["*string(length(fn_args))*"]", fn_args[end]))

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 484 in f839a0b

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 500 in f839a0b

    
           res = Core._call_in_world_total(world, make_oc, octup, rt, src, ocnargs, ocva, args[1].instance)::Core.OpaqueClosure

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Lines 504 to 514 in f839a0b

    
           push!(overdubbed_code, 
        
               Expr(:call, 
        
                   make_oc, 
        
                   octup, 
        
                   rt, 
        
                   src, 
        
                   ocnargs, 
        
                   ocva, 
        
                   farg 
        
                   ) 
        
                   )

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Lines 519 to 526 in f839a0b

    
           push!( 
        
               overdubbed_code, 
        
               Expr( 
        
                   :(call), 
        
                   oc, 
        
                   fn_args[2:end]... 
        
               ), 
        
           )

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Lines 530 to 533 in f839a0b

    
           push!( 
        
               overdubbed_code, 
        
               Core.ReturnNode(Core.SSAValue(length(overdubbed_code))) 
        
           )

[JuliaFormatter] _{reported by reviewdog 🐶}

Reactant.jl/src/utils.jl

Line 546 in f839a0b

src/TracedRArray.jl

src/utils.jl

commit 65e9976 Author: William Moses <gh@wsmoses.com> Date: Sat Dec 14 14:05:03 2024 -0600 Interp2 (EnzymeAD#365) * WIP: kernels * more files * fix * wip * wqtmp * wip * inc * continuing * wip * more work * inf rec * fix * overload working * continuing * continuing * push * fix `call_with_reactant_generator` for Julia 1.11 (EnzymeAD#359) * conversion * continuing * Cleanup * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Delete test/cuda.jl * fixup * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix apply * indep of change * minor fix in name * Update utils.jl * Interp take 2 * continuing adentures * delcode * fix * tmp * make * fix * cleanup * continuing * more working * further simplify * fx * more improvements * minus show * less prints * even fewer * confusion * tmp * force clean * force oc * clean * Rewrite * fixup * fix * fix * fix * fixup * fix * wip * safe prints * fix * fix * stackoverflow * cleanup * dyindex * rt * continue * clean * fix * fix * fix * fix * fixup * fix * fix * capture oc * compile perf * v1.11 fix * other way 'round * formatting --------- Co-authored-by: William Moses <wsmoses@cyclops.juliacomputing.io> Co-authored-by: jumerckx <31353884+jumerckx@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: jumerckx <julesmerckx12@gmail.com> commit 73899f5 Author: Avik Pal <avikpal@mit.edu> Date: Sat Dec 14 14:58:47 2024 +0530 fix: include files if they end with .jl (EnzymeAD#377) commit 9f96c09 Author: Sergio Sánchez Ramírez <15837247+mofeing@users.noreply.github.com> Date: Fri Dec 13 23:12:43 2024 +0100 Run CI on aarch64 (EnzymeAD#350) * Run CI on aarch64 * use julia pipeline for aarch64-linux * fix var * exclude aarch64-linux jobs from github ci commit b56e661 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri Dec 13 08:58:51 2024 +0530 chore: format code (EnzymeAD#371) Co-authored-by: mofeing <15837247+mofeing@users.noreply.github.com> commit 311498b Author: Anton Oresten <antonoresten@gmail.com> Date: Thu Dec 12 05:41:39 2024 +0100 feat: define outer `repeat` method for `TracedRArray` (EnzymeAD#361) * Add repeat method * Add repeat tests * Update test/basic.jl * Update src/TracedRArray.jl commit 8b90501 Author: Avik Pal <avikpal@mit.edu> Date: Thu Dec 12 10:11:00 2024 +0530 fix: ensure printing of wrapped ConcreteRArrays goes through our show (EnzymeAD#367) * fix: ensure printing of wrapped ConcreteRArrays goes through our show * fix: allow wrapped arrays in mapreduce commit ea97be3 Author: Sergio Sánchez Ramírez <sergio.sanchez.ramirez+git@bsc.es> Date: Wed Dec 11 22:02:14 2024 +0100 Ignore versioned manifests

Successor to #56808 which enables an opaque closure to be constructed with a specified world age (if, for example, the current world age isn't valid due to being in a generated function). Required for EnzymeAD/Reactant.jl#365

Successor to #56808 which enables an opaque closure to be constructed with a specified world age (if, for example, the current world age isn't valid due to being in a generated function). Required for EnzymeAD/Reactant.jl#365 (cherry picked from commit e46cc1a)

William Moses and others added 30 commits December 10, 2024 22:21

WIP: kernels

7159756

more files

f891bde

fix

14174db

wip

e401e4a

wqtmp

e7bc318

wip

ae6c7c6

inc

b8f206f

continuing

c414601

wip

9138a36

more work

c2ca4cb

inf rec

da328d3

fix

ad4d05b

overload working

750661a

continuing

12dec6c

continuing

a6cd104

push

db6e37b

fix call_with_reactant_generator for Julia 1.11 (#359)

8831f4d

conversion

e2ffe87

continuing

364823a

Cleanup

ff729ce

Apply suggestions from code review

3bd5608

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Delete test/cuda.jl

5e33afb

fixup

17c2f72

Apply suggestions from code review

4807a79

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix apply

51286bd

indep of change

bd40b69

minor fix in name

5b3329c

Update utils.jl

4af4a00

Interp take 2

8379f05

continuing adentures

246ec4e

wsmoses added 3 commits December 14, 2024 02:16

rt

2cff76e

continue

1d0cb8e

clean

f4349a9

github-actions bot reviewed Dec 14, 2024

View reviewed changes

wsmoses added 2 commits December 14, 2024 03:28

fix

a4ae31a

fix

0dbe20f

github-actions bot reviewed Dec 14, 2024

View reviewed changes

src/TracedRNumber.jl Outdated Show resolved Hide resolved

src/TracedUtils.jl Outdated Show resolved Hide resolved

src/TracedUtils.jl Outdated Show resolved Hide resolved

wsmoses added 2 commits December 14, 2024 03:47

fix

1c45d7e

fix

1ffb366

github-actions bot reviewed Dec 14, 2024

View reviewed changes

lib/ReactantCore/src/ReactantCore.jl Outdated Show resolved Hide resolved

src/linear_algebra.jl Outdated Show resolved Hide resolved

wsmoses added 2 commits December 14, 2024 03:52

fixup

3887575

fix

873e46b

github-actions bot reviewed Dec 14, 2024

View reviewed changes

ext/ReactantNNlibExt.jl Outdated Show resolved Hide resolved

src/Tracing.jl Outdated Show resolved Hide resolved

src/Tracing.jl Outdated Show resolved Hide resolved

src/linear_algebra.jl Outdated Show resolved Hide resolved

src/linear_algebra.jl Outdated Show resolved Hide resolved

fix

21244db

github-actions bot reviewed Dec 14, 2024

View reviewed changes

src/linear_algebra.jl Outdated Show resolved Hide resolved

src/linear_algebra.jl Outdated Show resolved Hide resolved

capture oc

70c3951

github-actions bot reviewed Dec 14, 2024

View reviewed changes

compile perf

f839a0b

github-actions bot reviewed Dec 14, 2024

View reviewed changes

wsmoses mentioned this pull request Dec 14, 2024

Interpreter fixes (prerequisite to CUDA support) #364

Closed

v1.11 fix

8073ecd

github-actions bot reviewed Dec 14, 2024

View reviewed changes

jumerckx added 2 commits December 14, 2024 20:31

other way 'round

585c485

formatting

0c56d35

wsmoses merged commit 65e9976 into main Dec 14, 2024

wsmoses deleted the interp2 branch December 14, 2024 20:05

	push!(
	overdubbed_code,
	Core.ReturnNode(Core.SSAValue(length(overdubbed_code)))
	)

	push!(overdubbed_code,
	Expr(:call,
	make_oc,
	octup,
	rt,
	src,
	ocnargs,
	ocva,
	farg
	)
	)

Conversation

wsmoses commented Dec 11, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants