[json] Allow null for string values#464
Merged
Enet4 merged 1 commit intoEnet4:masterfrom Mar 10, 2024
Merged
Conversation
e941328 to
200c819
Compare
200c819 to
7859de5
Compare
Enet4
approved these changes
Mar 10, 2024
Owner
There was a problem hiding this comment.
Well, this indeed works! I will approve and merge while leaving these notes on potential future changes:
- There is an extra allocation from
Vec<Option<Value>>toVec<Value>, but this also happens in a few other places as well. Maybe someone could find some time to fine-tune these later. - This takes care of the conversion from DICOM JSON to in-memory representations, but, thinking reciprocally, I suspect that empty values will still be encoded to DICOM JSON as empty strings with the current implementation. This is worth taking care of in a new pull request.
Thanks again for your contribution @feliwir. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://dicom.nema.org/dicom/2013/output/chtml/part18/sect_F.2.html in Section F.2.5
Based on #459