Skip to content

[json] Allow arbitrary element order for JsonDataElement#459

Merged
Enet4 merged 3 commits intoEnet4:masterfrom
feliwir:fix-json-deserialization
Mar 7, 2024
Merged

[json] Allow arbitrary element order for JsonDataElement#459
Enet4 merged 3 commits intoEnet4:masterfrom
feliwir:fix-json-deserialization

Conversation

@feliwir
Copy link
Copy Markdown
Contributor

@feliwir feliwir commented Mar 4, 2024

Keep the value of the "value" entry in memory until all fields have been read. This allows the "vr" field to occur after the "value" field

@Enet4 Enet4 added A-lib Area: library C-json Crate: dicom-json labels Mar 4, 2024
@feliwir feliwir force-pushed the fix-json-deserialization branch from 2bbadc0 to 49d8020 Compare March 6, 2024 11:02
@feliwir feliwir mentioned this pull request Mar 6, 2024
3 tasks
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a very minor suggestion inline, but other than that looks pretty good! Thank you @feliwir for reporting this case and providing a patch!

Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
Copy link
Copy Markdown
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Enet4 Enet4 merged commit ee1c818 into Enet4:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lib Area: library C-json Crate: dicom-json

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants