EmotiBit is identified by device Serial Number on Oscilloscope#188
Merged
EmotiBit is identified by device Serial Number on Oscilloscope#188
Conversation
7 tasks
11 tasks
produceconsumerobot
requested changes
Mar 31, 2023
Collaborator
produceconsumerobot
left a comment
There was a problem hiding this comment.
Review 01
Code review complete.
I'd prefer to see references to IP address removed from ofApp
Collaborator
Author
|
Merging to master as approved here: EmotiBit/EmotiBit_FeatherWing#264 (comment) |
version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Requirements
Non-dependent requirements
To test the functionality, you will also need to flash the EmotiBit with the FW linked in the PR below.
Issues Referenced
Documentation update
Code change explained
EmotiBit->EmotiBitWiFiHost (Oscilloscope)->EmotiBit Oscilloscope (ofApp)->GUIunordered_map<string, EmotibitInfo> _discoveredEmotibits;IP address,availability,lastSeen} (for old firmware)IP address,availability,lastSeen} (for new firmware)ofApp, where the "key" is used to populate the deviceGroup list.Testing
Test Configuration:
Checklist to allow merge
masterDIGITAL_WRITE_DEBUG= false (if set true while testing)ofxEmotiBitVersion.hScreenshots: