Skip to content

Feat transmit emotibit serial number to oscilloscope#24

Merged
nitin710 merged 4 commits intomasterfrom
feat-txEmotiBitSrNum
Apr 6, 2023
Merged

Feat transmit emotibit serial number to oscilloscope#24
nitin710 merged 4 commits intomasterfrom
feat-txEmotiBitSrNum

Conversation

@nitin710
Copy link
Collaborator

@nitin710 nitin710 commented Mar 21, 2023 •
edited
Loading

Description

  • Adds support to send EmotiBit serial number in the HELLO_HOST emotibit packet.
    • Used by new oscilloscope to identify emotibits by serial number
  • Bug fix:
  • Solved an issue with implicit cast from int to uint was starting an infinite while loop

Requirements

  • None

Required by

Issues Referenced

  • None

Documentation update

None

Testing

  • None

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Software
    • Passed testing on Windows
    • Passed testing on macOS
    • Passed testing on linux (ubuntu)
  • Firmware
    • Set testingMode to TestingMode::NONE
    • Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
    • Update version in EmotiBit.h
    • Update library.properties to the correct version (should match EmotiBit.h)
  • Update software bundle version in ofxEmotiBitVersion.h
  • doxygen style comments included for new code snippets
  • Required documentation udpated

Screenshots:

@nitin710 nitin710 changed the title Feat tx emoti bit sr num Feat tx emotibit sr num Mar 21, 2023
@nitin710 nitin710 mentioned this pull request Mar 21, 2023
Merged
12 tasks
nitin710
nitin710 commented Mar 21, 2023
View reviewed changes
src/EmotiBitPacket.cpp
}

int16_t EmotiBitPacket::getPacketKeyedValue(const String &packet, const String &key, String &value, uint16_t startChar)
int16_t EmotiBitPacket::getPacketKeyedValue(const String &packet, const String &key, String &value, int16_t startChar)
Copy link
Collaborator Author

@nitin710 nitin710 Mar 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewer:

in case of a "end of packet" scenario, a -1 returned by the called function (in this case EmotiBitPacket::getPacketElement) was being implicitly converted to 65535, which was creating an infinite do-while loop in the code segment below.

@nitin710 nitin710 changed the title Feat tx emotibit sr num Feat transmit emotibit serial number to oscilloscope Mar 21, 2023
@nitin710 nitin710 mentioned this pull request Mar 21, 2023
Merged
7 tasks
produceconsumerobot
produceconsumerobot approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@produceconsumerobot produceconsumerobot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review 01

Code review complete
Testing TBD

@nitin710 nitin710 merged commit 37e13bd into master Apr 6, 2023
@nitin710 nitin710 deleted the feat-txEmotiBitSrNum branch April 6, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@produceconsumerobot produceconsumerobot produceconsumerobot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nitin710 @produceconsumerobot