Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Infer the storage class for images/samplers/imagesamplers#567

Merged
XAMPPRocky merged 3 commits intomainfrom
infer-image-storage-class
Apr 1, 2021
Merged

Infer the storage class for images/samplers/imagesamplers#567
XAMPPRocky merged 3 commits intomainfrom
infer-image-storage-class

Conversation

@khyperia
Copy link
Copy Markdown
Contributor

@khyperia khyperia commented Mar 31, 2021

No description provided.

@khyperia khyperia requested a review from eddyb as a code owner March 31, 2021 11:19
XAMPPRocky
XAMPPRocky approved these changes Mar 31, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@XAMPPRocky XAMPPRocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we also want to remove the uniform_constant attribute? Are there reasons to keep it?

@khyperia
Copy link
Copy Markdown
Contributor Author

khyperia commented Mar 31, 2021

Not sure if it's used anywhere else, but if we do remove it, then we should also remove input/output/etc. (right now it's a consistent "include everything" thing, even things that aren't currently valid to place anywhere)

@XAMPPRocky
Copy link
Copy Markdown
Member

XAMPPRocky commented Mar 31, 2021

Not sure if it's used anywhere else, but if we do remove it, then we should also remove input/output/etc. (right now it's a consistent "include everything" thing, even things that aren't currently valid to place anywhere)

Sound good to me. I'll file a separate issue for that.

Also the tests need formatting 🙃

@khyperia
Copy link
Copy Markdown
Contributor Author

khyperia commented Mar 31, 2021

haha yeah, kinda sucks that cargo fmt doesn't catch the tests, have to run rustfmt tests/ui/**/*.rs, but whatever, at least a check is in CI~

eddyb
eddyb suggested changes Mar 31, 2021
View reviewed changes
@eddyb
Copy link
Copy Markdown
Contributor

eddyb commented Mar 31, 2021

Not sure if it's used anywhere else, but if we do remove it, then we should also remove input/output/etc. (right now it's a consistent "include everything" thing, even things that aren't currently valid to place anywhere)

I've been told OpenGL uses UniformConstant the same way Vulkan uses PushConstant (which explains the name).

Removing input/output and function/private/generic should probably be done regardless.

@XAMPPRocky XAMPPRocky mentioned this pull request Mar 31, 2021
Merged
@khyperia khyperia requested a review from eddyb April 1, 2021 07:00
@XAMPPRocky XAMPPRocky enabled auto-merge (squash) April 1, 2021 07:33
@XAMPPRocky XAMPPRocky merged commit 4fa73bd into main Apr 1, 2021
@XAMPPRocky XAMPPRocky deleted the infer-image-storage-class branch April 1, 2021 07:49
XAMPPRocky pushed a commit that referenced this pull request May 3, 2021
@khyperia @XAMPPRocky
Infer the storage class for images/samplers/imagesamplers (#567)
8947d62 
* Infer the storage class for images/samplers/imagesamplers

* format

* Move comment
This was referenced Mar 18, 2023
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@eddyb eddyb eddyb approved these changes

@XAMPPRocky XAMPPRocky XAMPPRocky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khyperia @XAMPPRocky @eddyb