This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Intercept panic calls and replace them with aborts.#305
Merged
mergify[bot] merged 6 commits intoEmbarkStudios:mainfrom Dec 3, 2020
LykenSol:panic-at-the-spirsco
Merged
Intercept panic calls and replace them with aborts.#305mergify[bot] merged 6 commits intoEmbarkStudios:mainfrom LykenSol:panic-at-the-spirsco
mergify[bot] merged 6 commits intoEmbarkStudios:mainfrom
LykenSol:panic-at-the-spirsco
Conversation
khyperia
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where "abort" currently is equivalent to
loop {}, but we could try to do something better in the future.(Ideally we'd use a future variant of
OpKillthat works in all shaders, and ideally has the right semantics of leaving some kind of indication that there was an error in some shader invocation, but that might be asking for too much)The reason this is "WIP", even if it does work (see the test changes), is because, in order to defer errors from creating unsupported constants (mostly&panic::Location) passed to panic entry-points, I had to turn them into zombies.So the tests only work because the panic calls are replaced with "abort"s, and the zombie constants never used.
From my discussion with @khyperia, we should be able to use zombies here (and in other places), if we can properly trackSpans for them, and I believe that's doable, but haven't gotten around to it.EDIT: that's all done, thanks to #311!