Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Track spans for zombies, even cross-crate.#311

Merged
mergify[bot] merged 2 commits intoEmbarkStudios:mainfrom
LykenSol:helpful-zombies
Dec 3, 2020
Merged

Track spans for zombies, even cross-crate.#311
mergify[bot] merged 2 commits intoEmbarkStudios:mainfrom
LykenSol:helpful-zombies

Conversation

@eddyb
Copy link
Copy Markdown
Contributor

@eddyb eddyb commented Dec 3, 2020

Before:

  error: OpBitcast on ptr without AddressingModel != Logical

After:

  error: OpBitcast on ptr without AddressingModel != Logical
    --> /home/eddy/.rustup/toolchains/nightly-2020-11-24-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panicking.rs:50:38
     |
  50 |     panic_fmt(fmt::Arguments::new_v1(&[expr], &[]));
     |                                      ^^^^^^^
     |

I wasn't sure whether we should start moving from immediate errors, to zombies, even for non-system code.

And for constants we still need some kind of Span propagation system, because only SpirValue::def knows the Span, the code creating the value originally does not. It might be a good idea for SpirValue itself to track "unspanned zombies" in general.

@eddyb eddyb requested a review from khyperia December 3, 2020 15:26
@mergify mergify bot merged commit d4f791f into EmbarkStudios:main Dec 3, 2020
@eddyb eddyb deleted the helpful-zombies branch December 3, 2020 16:28
This was referenced Dec 3, 2020
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@khyperia khyperia khyperia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eddyb @khyperia