This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Use the --component option in setup scripts#104
Merged
khyperia merged 1 commit intoEmbarkStudios:mainfrom Oct 22, 2020
Merged
Conversation
This should mean that if one of the required components is broken on a given nightly, rustup will try going backwards until it finds one which works.
repi
pushed a commit
that referenced
this pull request
Oct 23, 2020
This should mean that if one of the required components is broken on a given nightly, rustup will try going backwards until it finds one which works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should mean that if one of the required components is broken on a given nightly, rustup will try going backwards until it finds one which works.
This also makes it clear that the components are being installed for the nightly toolchain, such as if someone blindly copies the setup script, it will work even if they don't have nightly as their current toolchain (such as if they are not in the
I have tested this works both when no nightly toolchain is installed and when a nightly toolchain is already installed (the components appear in
rustup component list --toolchain nightly. Additionally, rustc, cargo and rustfmt etc. installed as normal.