Update some dependencies #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have stopped working in major version 3 (based on my testing in this project). The current major version of typeguard is 4. The issue looks like: agronholm/typeguard#364 This should probably only be a temporary solution. There are other libraries I could use. But also, it's not obvious that the added clarity of presentation from defining the top-level functions in the notebooks that use them, rather than in modules as I would ordinarily do, is justified, even in the absence of this issue. So it may be worthwhile to revisit that design decision for codegraph. But for now I'm keeping that as it is and holding back typeguard. This commit also updates typing-extensions to the next patch version.
EliahKagan
added a commit
that referenced
this pull request
Jul 3, 2023
I should've done this in #26 but didn't. Besides fixing that error, this commit improves the output in the notebooks in two other ways: 1. The Graphviz version used in this run handled some things better. See #5 and #6. (This is due to the system Graphviz on the machine I'm using to rerun this being old enough to have the bug discussed there. Using the conda environment instead of the poetry environment addresses that, because in the conda environment, the graphviz conda package is used.) 2. One of the Git repositories being visualized was absent from the test machine before. I cloned it so that graph would be redrawn rather than omittedw with an error.
EliahKagan
added a commit
that referenced
this pull request
Jul 3, 2023
#39) * Update dependencies (except typeguard) * Re-run notebooks * Hold back typeguard for conda too I should've done this in #26 but didn't. Besides fixing that error, this commit improves the output in the notebooks in two other ways: 1. The Graphviz version used in this run handled some things better. See #5 and #6. (This is due to the system Graphviz on the machine I'm using to rerun this being old enough to have the bug discussed there. Using the conda environment instead of the poetry environment addresses that, because in the conda environment, the graphviz conda package is used.) 2. One of the Git repositories being visualized was absent from the test machine before. I cloned it so that graph would be redrawn rather than omittedw with an error.
EliahKagan
added a commit
that referenced
this pull request
Dec 1, 2023
So it's easy to take grouped updates without updating typeguard to a higher major version, which the project does not currently support, as noted in #26.
EliahKagan
added a commit
that referenced
this pull request
Dec 1, 2023
So it's easy to take grouped updates without updating typeguard to a higher major version, which the project does not currently support, as noted in #26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But I'm keeping typeguard back at major version 2 for now, as detailed below.