chore: remove redundant words #1407
Conversation
|
Thanks! But any changes in src/secp256k1 need to be filed upstream at https://github.com/BlockstreamResearch/secp256k1-zkp/ (or maybe even upstreamer at https://github.com/bitcoin-core/secp256k1/ , though any issues there have probably been long since fixed). And any changes in src/simplicity need to be filed upstream at https://github.com/BlockstreamResearch/simplicity (we are up-to-date there, so any issues you see here will also be present there). |
chore: remove redundant words Signed-off-by: tianzedavid <cuitianze@aliyun.com>
Thanks for your reply. Reverted. Please review again. |
|
utACK e982627 -- though I am still unsure if we will accept this, since these files were unchanged since our fork of Bitcoin Core and we may want to let these fixes come in during our rebase process. |
It's ok, thank you for your reply |
| `getblocktemplate` call `TestBlockValidity()`, which applies the UTXO set | ||
| changes to a temporary cache. Similarly, mempool consistency checks, which are | ||
| frequent on regtest, also apply the the UTXO set changes to a temporary cache. | ||
| frequent on regtest, also apply the UTXO set changes to a temporary cache. |
There was a problem hiding this comment.
this has been fixed upstream https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md?plain=1#L178
|
fixed from upstream |
033acdf chore: remove redundant word (tianzedavid) Pull request description: Remove redundant word For ElementsProject/elements#1407 ACKs for top commit: maflcko: lgtm ACK 033acdf delta1: ACK 033acdf Tree-SHA512: ec9c9951c0153fa598d7733cfba287217c4a3389090a6d106d9144ac9cb1c13cf854f660fe187dad992b6ae1b252c01f1764af5bba5bdf8703b978d04cdb190f
033acdf chore: remove redundant word (tianzedavid) Pull request description: Remove redundant word For ElementsProject/elements#1407 ACKs for top commit: maflcko: lgtm ACK 033acdf delta1: ACK bitcoin@033acdf Tree-SHA512: ec9c9951c0153fa598d7733cfba287217c4a3389090a6d106d9144ac9cb1c13cf854f660fe187dad992b6ae1b252c01f1764af5bba5bdf8703b978d04cdb190f
remove redundant words