Skip to content

docs(adr): prefer registry truth over cargo output#258

Merged
EffortlessSteven merged 1 commit into
mainfrom
docs/reconcile-adr
May 13, 2026
Merged

docs(adr): prefer registry truth over cargo output#258
EffortlessSteven merged 1 commit into
mainfrom
docs/reconcile-adr

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 13, 2026

Copy link
Copy Markdown
Member

Summary:

  • add SHIPPER-ADR-0002 for the Reconcile lane
  • record the durable decision that Cargo output is a classification hint and registry state is authoritative
  • keep runtime behavior and support tiers unchanged

Validation:

  • cargo xtask check-doc-contracts --mode advisory
  • cargo xtask policy-report
  • cargo fmt --all -- --check
  • cargo xtask check-file-policy --mode blocking-allowlist
  • git diff --cached --check

Non-goals:

  • no runtime publish-engine behavior change
  • no support-tier promotion
  • no Reconcile implementation

@gemini-code-assist

gemini-code-assist Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 13, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@factory-droid

factory-droid Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Droid finished @EffortlessSteven's task —— View job

Droid review completed.

Review Summary:
LGTM — PR #258 adds a single ADR document that passes all validation gates (doc-contracts advisory, file-policy blocking-allowlist). The ADR is structurally complete, references existing linked artifacts, and correctly records the registry-truth-over-cargo-output decision with no runtime behavior change.

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 30 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 231b6a6d-19a5-434f-8ab5-533c19f66e64

📥 Commits

Reviewing files that changed from the base of the PR and between babb917 and 39e48fe.

📒 Files selected for processing (1)
  • docs/adr/SHIPPER-ADR-0002-registry-truth-over-cargo-output.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/reconcile-adr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 4b8b3ef into main May 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven