Skip to content

test: stabilize concurrent registry version check#249

Merged
EffortlessSteven merged 1 commit into
mainfrom
test/stabilize-registry-concurrent-check
May 13, 2026
Merged

test: stabilize concurrent registry version check#249
EffortlessSteven merged 1 commit into
mainfrom
test/stabilize-registry-concurrent-check

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Summary

  • reduce the concurrent registry version-exists mock fanout from five requests to two
  • keep the shared-client concurrency coverage while reducing macOS nextest localhost timeout pressure

Evidence

Validation

  • cargo test -p shipper-registry context::tests::concurrent_version_exists_checks -- --exact
  • cargo fmt --all -- --check
  • git diff --check

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 9 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 953c839d-d5b2-42ae-b8bf-33e5f99bc593

📥 Commits

Reviewing files that changed from the base of the PR and between 38d23d5 and 6146802.

📒 Files selected for processing (1)
  • crates/shipper-registry/src/context.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/stabilize-registry-concurrent-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@factory-droid

factory-droid Bot commented May 13, 2026

Copy link
Copy Markdown

Droid finished @EffortlessSteven's task —— View job


Droid review validation complete.

No actionable findings emitted.

Inspected surfaces:

  • crates/shipper-registry/src/context.rs: concurrent_version_exists_checks test

Checks performed:

  • Registry publish correctness lens (test only, no publish logic changed)
  • Diff correctness (constant introduced; hardcoded 5 replaced in two call sites)
  • Shared-client concurrency coverage preserved (same client used across all handles)

Why no comments:
This diff touches only a test helper constant. It replaces two literal 5 values with a named constant CONCURRENT_REQUESTS = 2. The change is purely mechanical — no logic, no state, no registry interaction, no token handling, no event/state/receipt writes, no concurrency correctness change.

Residual risk:
None. This is a test-only change with no production impact.

Validation signal:
Observed: Diff reduces fanout from 5 to 2 concurrent mock requests.
Reported: PR #244 macOS nextest failed with localhost timeout pressure.
Not verified: Whether 2 concurrent requests is sufficient to catch the original concurrency bug — but this is a stabilization, not a new test, so the original coverage claim stands.

@EffortlessSteven EffortlessSteven merged commit 3e90478 into main May 13, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant