Skip to content

docs(adr): record claims become checkable state#244

Merged
EffortlessSteven merged 2 commits into
mainfrom
docs/claims-checkable-state-adr
May 13, 2026
Merged

docs(adr): record claims become checkable state#244
EffortlessSteven merged 2 commits into
mainfrom
docs/claims-checkable-state-adr

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 13, 2026

Copy link
Copy Markdown
Member

Summary

  • add SHIPPER-ADR-0001 for the durable claims-as-checkable-state decision
  • record that stable claims need support-tier proof and agent goals need plan/spec links
  • keep policy ledgers authoritative for exceptions and receipts

Scope boundary

This is PR 6 only: one ADR artifact. It intentionally does not add active goals, plans, checker code, CI wiring, README claim changes, or #195 release proof work.

Validation

  • cargo fmt --all -- --check
  • cargo xtask check-file-policy --mode blocking-allowlist
  • cargo xtask policy-report

@gemini-code-assist

gemini-code-assist Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 13, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 25 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a477066d-4014-477b-bc8b-df781233a0fe

📥 Commits

Reviewing files that changed from the base of the PR and between 3e90478 and 2a12902.

📒 Files selected for processing (1)
  • docs/adr/SHIPPER-ADR-0001-claims-become-checkable-state.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/claims-checkable-state-adr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@factory-droid

factory-droid Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Droid finished @EffortlessSteven's task —— View job

Droid Review Summary — PR #244 ✅

Result: Approved — No actionable findings.

Inspected surfaces:

Checks performed:

  • ADR metadata completeness (status, owner, created, milestone, linked fields)
  • Proof commands validity (cargo xtask check-file-policy --mode blocking-allowlist, cargo xtask policy-report, cargo fmt --all -- --check)
  • Context and consequences alignment with existing source-of-truth stack docs
  • No violations of clean-review requirements

Why no comments:
The diff is a pure documentation artifact. No code changes, no behavioral surface touched. ADR follows project conventions with accurate cross-references and valid proof commands.

Residual risk:
None — this is a standalone ADR with no active code or CI behavior change.

Validation signal:

  • Observed: ADR file structure, metadata, and linked references
  • Reported: PR description scope boundary ("PR 6 only: one ADR artifact")
  • Not verified: Execution of proof commands (not required for doc-only PR)

@EffortlessSteven EffortlessSteven mentioned this pull request May 13, 2026
Merged
@factory-droid

factory-droid Bot commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Droid finished @EffortlessSteven's task —— View job

Droid Review Summary — PR #244 ✅

Result: Approved — No actionable findings.

Inspected surfaces:

Checks performed:

  • ADR metadata completeness (status, owner, created, milestone, linked fields)
  • Proof commands validity (cargo xtask check-file-policy --mode blocking-allowlist, cargo xtask policy-report, cargo fmt --all -- --check)
  • Context and consequences alignment with existing source-of-truth stack docs
  • No violations of clean-review requirements

Why no comments:
The diff is a pure documentation artifact. No code changes, no behavioral surface touched. ADR follows project conventions with accurate cross-references and valid proof commands.

Residual risk:
None — this is a standalone ADR with no active code or CI behavior change.

Validation signal:

  • Observed: ADR file structure, metadata, and linked references
  • Reported: PR description scope boundary ("PR 6 only: one ADR artifact")
  • Not verified: Execution of proof commands (not required for doc-only PR)

factory-droid[bot]
factory-droid Bot reviewed May 13, 2026
View reviewed changes

@factory-droid factory-droid Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — PR #244 adds a single documentation artifact (SHIPPER-ADR-0001) following project conventions. All cross-references verified, proof commands valid, structure matches the ADR template. No code changes, no security issues, no actionable findings.

@EffortlessSteven EffortlessSteven merged commit 780871f into main May 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@factory-droid factory-droid[bot] factory-droid[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven