shared: Don't check the Cyttsp5 REL bit #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reMarkable vendor kernel incorrectly sets the REL bit for the Cyprus Cyttsp5 driver. The check in Oxide currently relies on this bug. The in progress upstream Cyttsp5 kernel driver doesn't set the REL bit. This patch removes the check from Oxide so that it works on both the mainline kernel as well as the vendor kernel. Signed-off-by: Alistair Francis <alistair@alistair23.me>
|
Code Climate has analyzed commit 67f158c and detected 0 issues on this pull request. View more on Code Climate. |
alistair23
added a commit
to alistair23/linux
that referenced
this pull request
Dec 22, 2021
Oxide currently requires the REL bit to be set for the Cyttp5 touchscreen controller. Until this is fixed by Eeems-Org/oxide#234 let's set the bit as a hack. Signed-off-by: Alistair Francis <alistair@alistair23.me>
Eeems
approved these changes
Jan 4, 2022
alistair23
added a commit
to alistair23/linux
that referenced
this pull request
Jan 9, 2022
Oxide currently requires the REL bit to be set for the Cyttp5 touchscreen controller. Until this is fixed by Eeems-Org/oxide#234 let's set the bit as a hack. Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
added a commit
to alistair23/linux
that referenced
this pull request
Jan 9, 2022
Oxide currently requires the REL bit to be set for the Cyttp5 touchscreen controller. Until this is fixed by Eeems-Org/oxide#234 let's set the bit as a hack. Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
added a commit
to alistair23/linux
that referenced
this pull request
Jan 10, 2022
Oxide currently requires the REL bit to be set for the Cyttp5 touchscreen controller. Until this is fixed by Eeems-Org/oxide#234 let's set the bit as a hack. Signed-off-by: Alistair Francis <alistair@alistair23.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reMarkable vendor kernel incorrectly sets the REL bit for the Cyprus
Cyttsp5 driver. The check in Oxide currently relies on this bug.
The in progress upstream Cyttsp5 kernel driver doesn't set the REL bit.
This patch removes the check from Oxide so that it works on both the
mainline kernel as well as the vendor kernel.
Signed-off-by: Alistair Francis alistair@alistair23.me