Skip to content

Conversation

@tamarl08
Copy link
Contributor

When scale_with is raw scaling should not be performed. This is the default case in rsmxval calls to rsmeval.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d372d66) 95.90% compared to head (659a3ea) 95.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          59       59           
  Lines        9297     9297           
=======================================
  Hits         8916     8916           
  Misses        381      381           
Impacted Files Coverage Δ
tests/test_experiment_rsmeval.py 97.53% <ø> (ø)
rsmtool/rsmeval.py 97.80% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist desilinguist merged commit 3d3b46e into main Jul 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the 611-fix-scale-with branch July 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rsmeval should not do scaling when scale_with is set to 'raw'

4 participants