GetInfo - Support Tile ID #3330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It lacks sanity checks for out of range map access. Can you test what happens when the tile location is out of bounds in +-x and y direction? Guess it will crash. |
Now the behaviors are similar both in Maniacs and EasyRPG.
fdelapena
approved these changes
Jan 8, 2025
carstene1ns
reviewed
Jan 8, 2025
Ghabry
approved these changes
Jan 9, 2025
Member
|
For testing: https://easyrpg.org/play/pr3330/?game=issue-3330&test-play Hold CTRL and walk on the arrows. @jetrotal The editor you use ignores the .editorconfig file. Leading whitespace is not stripped. |
27 tasks
tsdko
added a commit
to tsdko/easyrpg-player
that referenced
this pull request
Oct 25, 2025
According to tpc.exe bitfield offsets for Get Tile ID start at 0, not 1. I've modified the test map from pull EasyRPG#3330 and confirmed (on RPG_RT version 211010, im, patch_en) the command behaves as expected only if the initial offset is 0.
tsdko
added a commit
to tsdko/easyrpg-player
that referenced
this pull request
Oct 25, 2025
According to tpc.exe bitfield offsets for Get Tile ID start at 0, not 1. I've modified the test map from EasyRPG#3330 and confirmed (on RPG_RT version 211010, im, patch_en) the command behaves as expected only if the initial offset is 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of
Get Game Info -> Get Tile, started by @ToolMan2kMap of it:
EasyRPG TileID Demo.zip