Skip to content

[Bug Fix] Fix Several Evolving Item Bugs#4992

Merged
joligario merged 3 commits intoEQEmu:masterfrom
neckkola:Fix_EvolvingItemsUpdatesAug2025
Sep 8, 2025
Merged

[Bug Fix] Fix Several Evolving Item Bugs#4992
joligario merged 3 commits intoEQEmu:masterfrom
neckkola:Fix_EvolvingItemsUpdatesAug2025

Conversation

@neckkola
Copy link
Copy Markdown
Contributor

@neckkola neckkola commented Aug 25, 2025

Description

Reports of a few issues with evolving items:

  1. Evolving items can be mailed, but cannot be retrieved. It makes the sound like it's being delivered, but never detaches and goes into the inventory.
  2. Evolving items cannot be placed on vendors for purchase. You can list one, but multiples will result in only the last entry being displayed.
  3. When sold to a vendor, evolving items cannot be repurchased. The merchant UI crashes out and you must camp and come back or zone to buy or sell anything again.
  4. Minor, but linking evolving items results in a number or letter prefixing the item name at all but the final evolution level.
    Please include a summary of the changes and the related issue (Why is this change necessary). Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR resolves 1, 2 and 3 above. Please note, when selling an evolving item to a merchant, any progression is lost. When repurchased, progression is set at 0.

I am not an expert on saylinks, so have not looked into item 4. Anyone with info in this regard please let me know. If I have some time, can look into it further.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Testing

Tested with RoF2 Client.

Clients tested:
RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • [X - Once approved] I have made corresponding changes to the documentation (if applicable, if not delete this line)
  • I own the changes of my code and take responsibility for the potential issues that occur
  • If my changes make database schema changes, I have tested the changes on a local database (attach image). Updated version.h CURRENT_BINARY_DATABASE_VERSION to the new version. (Delete this if not applicable)

@Kinglykrab Kinglykrab changed the title [BugFix] Evolving item updates aug2025 [Bug Fix] Evolving item updates aug2025 Aug 30, 2025
@Kinglykrab Kinglykrab changed the title [Bug Fix] Evolving item updates aug2025 [Bug Fix] Fix Several Evolving Item Bugs Aug 30, 2025
@neckkola neckkola force-pushed the Fix_EvolvingItemsUpdatesAug2025 branch from faacbcf to 94d7800 Compare September 3, 2025 21:16
@neckkola
Copy link
Copy Markdown
Contributor Author

neckkola commented Sep 3, 2025

Rebased and corrected an issue with certain potions.

@neckkola neckkola force-pushed the Fix_EvolvingItemsUpdatesAug2025 branch from 94d7800 to 07a972d Compare September 7, 2025 23:30
@joligario joligario merged commit 9b14313 into EQEmu:master Sep 8, 2025
1 check passed
joligario added a commit to ProjectEQ/peqphpeditor that referenced this pull request Sep 14, 2025
@joligario joligario mentioned this pull request Sep 15, 2025
Valorith pushed a commit to Valorith/Server that referenced this pull request Mar 22, 2026
47 test cases across 15 sections covering all evolution types (XP, kill
count, mob race, zone), activation/timer mechanics, evolution completion,
augment handling, XP transfer window, merchant/parcel interactions,
persistence, GM commands, edge cases, and regression tests for PRs EQEmu#4607,
EQEmu#4992, #8, and #98. Includes ready-to-run SQL setup for 5 test item
families with low thresholds for fast manual testing.

https://claude.ai/code/session_017wrKmjuMTicYybGCRiBBFG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants