[Player Event Logs] Don't Clear Event Data on ETL Events#4913
Merged
[Player Event Logs] Don't Clear Event Data on ETL Events#4913
Conversation
joligario
approved these changes
Jun 11, 2025
Merged
joligario
added a commit
to ProjectEQ/peqphpeditor
that referenced
this pull request
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When ETL events are turned on, we empty the JSON data payload. This causes issues with viewing the data through tools like Spire. As a fundamental design decision as to how we want to use this tooling, we are re-introducing the data back into the field for simplicity of use.
When operators use ETL features, they are opting into double recording data. The data in tables can be used for different ways and it doesn't make sense to build tooling conditionally around both tables depending on if certain things are turned on/off or not.
To offset this, I'm enabling table compression on the table which will at least save 50% of the table storage size.
Type of change
Testing
Ran the migration on a 40GB player event table, went down to 20GB. Event data no longer gets truncated.
Checklist