Skip to content

[Player Event Logs] Don't Clear Event Data on ETL Events#4913

Merged
joligario merged 2 commits intomasterfrom
akkadius/dont-clear-event-data-etl
Jun 25, 2025
Merged

[Player Event Logs] Don't Clear Event Data on ETL Events#4913
joligario merged 2 commits intomasterfrom
akkadius/dont-clear-event-data-etl

Conversation

@Akkadius
Copy link
Copy Markdown
Contributor

Description

When ETL events are turned on, we empty the JSON data payload. This causes issues with viewing the data through tools like Spire. As a fundamental design decision as to how we want to use this tooling, we are re-introducing the data back into the field for simplicity of use.

When operators use ETL features, they are opting into double recording data. The data in tables can be used for different ways and it doesn't make sense to build tooling conditionally around both tables depending on if certain things are turned on/off or not.

To offset this, I'm enabling table compression on the table which will at least save 50% of the table storage size.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Optimization

Testing

Ran the migration on a 40GB player event table, went down to 20GB. Event data no longer gets truncated.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur
  • If my changes make database schema changes, I have tested the changes on a local database (attach image). Updated version.h CURRENT_BINARY_DATABASE_VERSION to the new version. (Delete this if not applicable)

@Akkadius Akkadius changed the title Akkadius/dont clear event data etl [Player Event Logs] Don't Clear Event Data on ETL Events Jun 11, 2025
@joligario joligario merged commit f025e57 into master Jun 25, 2025
2 checks passed
@joligario joligario deleted the akkadius/dont-clear-event-data-etl branch June 25, 2025 00:15
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
joligario added a commit to ProjectEQ/peqphpeditor that referenced this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants