Skip to content

[Netcode] Resend Logic Adjustments#4900

Merged
Akkadius merged 13 commits intomasterfrom
akkadius/timeout-adjust
May 18, 2025
Merged

[Netcode] Resend Logic Adjustments#4900
Akkadius merged 13 commits intomasterfrom
akkadius/timeout-adjust

Conversation

@Akkadius
Copy link
Copy Markdown
Contributor

@Akkadius Akkadius commented May 18, 2025

Description

This PR reverts #4895 and fixes a few things by re-introducing the ack flag but also making sure the ack flag gets reset under unordered acks as well as resetting the ack flag when a second has passed. This prevents the flag from somehow putting clients in an infinite state.

This has dramatically fixed unnecessary resends and fixed issues observed on PEQ.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Extensive testing and hours with a 100 boxer on PEQ.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit e657953 into master May 18, 2025
2 checks passed
@Akkadius Akkadius deleted the akkadius/timeout-adjust branch May 18, 2025 16:19
@Akkadius Akkadius mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants