Skip to content

[Netcode] Resend Logic Adjustments#4895

Merged
Akkadius merged 2 commits intomasterfrom
akkadius/netcode-tweaks
May 16, 2025
Merged

[Netcode] Resend Logic Adjustments#4895
Akkadius merged 2 commits intomasterfrom
akkadius/netcode-tweaks

Conversation

@Akkadius
Copy link
Copy Markdown
Contributor

Description

This PR aims to address a rarer report where clients can sometimes "randomly" disconnect. The working theory is that in rarer circumstances client connections end in a state where their acked flag is not getting reset. This PR removes the reliance on the ack flag entirely and simplifies the resend logic because we now have windowing logic which achieves the same thing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested stress flooding my client with 100's of NPC's. No issue. Repopped with instant responsiveness.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit a1d414d into master May 16, 2025
2 checks passed
@Akkadius Akkadius deleted the akkadius/netcode-tweaks branch May 16, 2025 21:46
@Akkadius Akkadius mentioned this pull request May 18, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants