Skip to content

[Databuckets] Implement Cache in World#4920

Merged
Akkadius merged 1 commit intoakkadius/databuckets-nested-cachingfrom
akkadius/world-load-databuckets
Jun 25, 2025
Merged

[Databuckets] Implement Cache in World#4920
Akkadius merged 1 commit intoakkadius/databuckets-nested-cachingfrom
akkadius/world-load-databuckets

Conversation

@Akkadius
Copy link
Copy Markdown
Contributor

@Akkadius Akkadius commented Jun 16, 2025

Description

As a follow up to #4918 - loads cache into world and unloads on client deconstructor

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

Loading

 World | Client Log | HandleSendLoginInfoPacket Checking authentication id [137381]
 World | MySQL Quer | QueryDatabase SELECT id FROM character_data WHERE account_id = 1 AND deleted_at IS NULL -- (1 row returned) (0.000153s)
 World | MySQL Quer | QueryDatabase SELECT id, `key`, value, expires, account_id, character_id, npc_id, bot_id, zone_id, instance_id FROM data_buckets WHERE character_id IN (1) AND (`expires` > 1750113726 OR `expires` = 0) -- (17 rows returned) (0.000374s)

Unloading

 World |    Info    | Process Removing client from [192.168.97.1:41284]
 World | MySQL Quer | QueryDatabase SELECT id FROM character_data WHERE account_id = 1 AND deleted_at IS NULL -- (1 row returned) (0.000574s)
 World | Client Log | SetOnline Online status [schecterx] (1) status [Offline] (1)

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit 09aeb6a into akkadius/databuckets-nested-caching Jun 25, 2025
2 checks passed
@Akkadius Akkadius deleted the akkadius/world-load-databuckets branch June 25, 2025 17:38
Akkadius added a commit that referenced this pull request Jun 25, 2025
@Akkadius
[Databuckets] Nested Caching (#4917)
ea96cbf 
* [Databuckets] Nested Caching

* One more

* Update benchmark_databuckets.cpp

* Add caching tests

* Fix tests and scoping

* Update databuckets.cpp

* Fix tests

* Rebase fixes

* [Databuckets] Implement Cache in World (#4920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KimLS KimLS KimLS approved these changes

@joligario joligario joligario approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Akkadius @KimLS @joligario