Skip to content

[Feature] Enable spawn attribute for NPCTintID#4871

Merged
Akkadius merged 9 commits intoEQEmu:masterfrom
neckkola:Add_ScriptingForSpawnAppearance
May 15, 2025
Merged

[Feature] Enable spawn attribute for NPCTintID#4871
Akkadius merged 9 commits intoEQEmu:masterfrom
neckkola:Add_ScriptingForSpawnAppearance

Conversation

@neckkola
Copy link
Copy Markdown
Contributor

Description

With work underway for additional content, the NPCTintID is required to enable certain visual effects.

This update enables:

  • LUA/Perl scripting for setting the NPCTintId via SetNPCTintIndex
  • updates #npcedit to all for the NPCTintID to be changed within the db
  • add npc_tint_id to the npc_types table with a default of 0 (no tint and mirrors previous behaviour)
  • updates the RoF2 spawn logic to utilize NPCTintID attribute

RoF2 uses 78 IDs for the NPCTint and are found in resources/npct.ini

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

https://www.youtube.com/watch?v=UoqyrWdHQwY

image
image
image

Clients tested:
RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur
  • If my changes make database schema changes, I have tested the changes on a local database (attach image). Updated version.h CURRENT_BINARY_DATABASE_VERSION to the new version. (Delete this if not applicable)

@neckkola
Copy link
Copy Markdown
Contributor Author

I will fix up the error shortly.

Copy link
Copy Markdown
Contributor

@fryguy503 fryguy503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my environment and as expected.

@Akkadius Akkadius force-pushed the Add_ScriptingForSpawnAppearance branch from afe07ec to 27b08f1 Compare May 15, 2025 01:10
@Akkadius Akkadius enabled auto-merge (squash) May 15, 2025 01:12
@Akkadius Akkadius merged commit 20da490 into EQEmu:master May 15, 2025
1 check passed
@Akkadius Akkadius mentioned this pull request May 15, 2025
joligario added a commit to ProjectEQ/peqphpeditor that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants