Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Allowing a name to be an empty string (develop branch)#791

Merged
bradlhart merged 2 commits intoEOSIO:developfrom
Buzhanin:updateauth_owner_fix_dev
Sep 11, 2020
Merged

Allowing a name to be an empty string (develop branch)#791
bradlhart merged 2 commits intoEOSIO:developfrom
Buzhanin:updateauth_owner_fix_dev

Conversation

@Buzhanin
Copy link
Copy Markdown

@Buzhanin Buzhanin commented Sep 3, 2020 •
edited
Loading

This is a clone of !790 created for a develop branch

Change Description

In order to update owner permission of an account the name of it's parent permission should be set to an empty string

Example:

{
    "account": "eosio",
    "name": "updateauth",
    "authorization": [{
        "actor": "someaccount"
        ",
        "permission": "owner"
    }],
    "data": {
        "account": "someaccount",
        "permission": "owner",
        "parent": "",
        "auth": {
            "threshold": 1,
            "keys": [{
                "key": "NEW_PUBLIC_KEY",
                "weight": 1
            }],
            "accounts": [],
            "waits": []
        }
    }
}

Current regex validation doesn't allow fields of name type to be an empty string. It causes a fail in serialisation of above mentioned action.

@Buzhanin Buzhanin mentioned this pull request Sep 3, 2020
Closed
@bradlhart bradlhart merged commit 95f1f9b into EOSIO:develop Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bradlhart bradlhart bradlhart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Buzhanin @bradlhart