Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Allowing a name to be an empty string.#790

Closed
Buzhanin wants to merge 1 commit intoEOSIO:masterfrom
Buzhanin:updateauth_owner_fix
Closed

Allowing a name to be an empty string.#790
Buzhanin wants to merge 1 commit intoEOSIO:masterfrom
Buzhanin:updateauth_owner_fix

Conversation

@Buzhanin
Copy link
Copy Markdown

@Buzhanin Buzhanin commented Aug 12, 2020

Change Description

In order to update owner permission of an account the name of it's parent permission should be set to an empty string

Example:

{
    "account": "eosio",
    "name": "updateauth",
    "authorization": [{
        "actor": "someaccount"
        ",
        "permission": "owner"
    }],
    "data": {
        "account": "someaccount",
        "permission": "owner",
        "parent": "",
        "auth": {
            "threshold": 1,
            "keys": [{
                "key": "NEW_PUBLIC_KEY",
                "weight": 1
            }],
            "accounts": [],
            "waits": []
        }
    }
}

Current regex validation doesn't allow fields of name type to be an empty string. It causes a fail in serialisation of above mentioned action.

@jeffreyssmith2nd jeffreyssmith2nd changed the base branch from master to develop August 14, 2020 14:45
@jeffreyssmith2nd jeffreyssmith2nd changed the base branch from develop to master August 14, 2020 14:45
@yelagins
Copy link
Copy Markdown

yelagins commented Sep 3, 2020

Hey! When will it be fixed?

@bradlhart bradlhart changed the base branch from master to develop September 3, 2020 19:01
@bradlhart bradlhart changed the base branch from develop to master September 3, 2020 19:02
@bradlhart
Copy link
Copy Markdown
Contributor

bradlhart commented Sep 3, 2020

Could you make these changes against develop? Unfortunately, switching your base branch to develop causes unexpected changes as a result.

@Buzhanin Buzhanin mentioned this pull request Sep 3, 2020
Merged
@Buzhanin
Copy link
Copy Markdown
Author

Buzhanin commented Sep 3, 2020

Could you make these changes against develop? Unfortunately, switching your base branch to develop causes unexpected changes as a result.

I've created a new PR for develop branch !791

@bradlhart
Copy link
Copy Markdown
Contributor

bradlhart commented Sep 11, 2020

Closing in favor of #791

@bradlhart bradlhart closed this Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bradlhart bradlhart Awaiting requested review from bradlhart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Buzhanin @yelagins @bradlhart