This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix broken key recovery for r1 signatures#731
Closed
jnordberg wants to merge 3 commits intoEOSIO:developfrom
Closed
Fix broken key recovery for r1 signatures#731jnordberg wants to merge 3 commits intoEOSIO:developfrom
jnordberg wants to merge 3 commits intoEOSIO:developfrom
Conversation
Closed
Contributor
|
@jnordberg Thank you for the submission. These fixes look good. Since I want to be sure to add testing around this updated functionality (and have another code fix), I'm going to open another PR instead of merging this in, but will make sure you receive credit for it. I'll be tracking the work #732 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recovery param was not extracted correctly causing all pubkey recovery attempts to fail or output the wrong pubkey for secp256r1 signatures.
Test case: