Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

R1 Signatures Incorrect #732

@jlamarr22

Description

@jlamarr22

Version of EOSJS
All

Describe the bug
R1 signatures are not generated properly.

To Reproduce
Steps to reproduce the behavior:

  1. Try to sign data with an R1 key.
  2. Try to recover public key from signature.

Expected behavior

  1. You may or may not receive an error about high r values. (needs canonical check)
  2. You won't receive the correct public key. (needs recovery parameter updates)

Additional context
#731 is where the bug was originally reported. This issue will track progress. New PR will be created to add tests and another update for canonical checking.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions