Implemented the keypad core module.
#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
elpekenin
reviewed
Aug 10, 2024
Contributor
elpekenin
left a comment
There was a problem hiding this comment.
(maybe useless) feedback based on quick reading... feel free to ignore it :)
Fixed an invalid type hint, thanks to a suggestion by elpekenin. Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com>
elpekenin
reviewed
Aug 12, 2024
EGJ-Moorington
added a commit
that referenced
this pull request
Jun 16, 2025
Implemented the `keypad` core module.
EGJ-Moorington
added a commit
that referenced
this pull request
Jun 16, 2025
Implemented the `keypad` core module.
EGJ-Moorington
added a commit
that referenced
this pull request
Jun 17, 2025
Implemented the `keypad` core module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
keypadcore module for better compatibility and flexibility when using this library.Resolves #1