change author key to a string in the manifest#1731
Closed
numberMumbler wants to merge 1 commit intoEFForg:masterfrom
Closed
change author key to a string in the manifest#1731numberMumbler wants to merge 1 commit intoEFForg:masterfrom
numberMumbler wants to merge 1 commit intoEFForg:masterfrom
Conversation
The specification for Firefox extensions specifies the value of author should be a string. Updated the release utils script that modifies the email when building the Firefox extension. Simplified, since we aren't changing from object to string any more.
ab85509 to
341e301
Compare
Member
|
We originally added the author field in c305972. |
Member
|
Merged in 29669e0. |
ghostwords
pushed a commit
that referenced
this pull request
Oct 17, 2017
Change author field value to a string in the manifest.
ghostwords
added a commit
that referenced
this pull request
Oct 25, 2017
Member
|
Reverted in 9cd573d; see #1728 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification for Firefox extensions specifies the value of author should be a string. Fixes #1728
Also, updated the release utils script that modifies the email when building the Firefox extension. Simplified, since we aren't changing from object to string any more.
Published then updated in Chrome Web Store to verify that changing the author from an object to a string wouldn't break anything on the Chrome side. Manually executed the
sedscript to verify that only the author value gets changed.