Skip to content

Conversation

@dnenov
Copy link
Contributor

@dnenov dnenov commented Aug 23, 2023

Purpose

A small PR based on the new API route provided by @zeusongit user/votes. Will fetch all votes made by current user.

  • add route to fetch votes made by current user

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@zeusongit
@QilongTang

FYIs

- add route to fetch votes made by current user
@QilongTang QilongTang requested a review from zeusongit August 23, 2023 16:06
@zeusongit zeusongit merged commit 3794683 into DynamoDS:master Aug 23, 2023
dnenov added a commit to dnenov/Dynamo that referenced this pull request Sep 7, 2023
- still not showing the new 'GetUserVotes' request that was added with this PR DynamoDS/PackageManagerClient#84
reddyashish pushed a commit to DynamoDS/Dynamo that referenced this pull request Oct 27, 2023
* votes cherry pick

- adding changes connected to the 'votes' behavior

* Greg update

- still not showing the new 'GetUserVotes' request that was added with this PR DynamoDS/PackageManagerClient#84

* votes cherry pick

- voting for packages functionality reinstated
- checking for user votes on loading
- if the user has already voted for a package prevents from voting again
- ui updates

* minor fixes

- now correctly updates the SeachElement item inside the PackageManagerPackagesControl 'votes' icon when user has voted for a package
- now allows to vote for a package right after a package has been installed

* Greg - Duplicate 'PackageReference' items found

- removed duplicate package references

* references reconciliation

- reconciled meshed up references
- comments

* reference fix

- last reference?

* revert assemblyinfo changes

- revert changes made by mistake

* failing tests fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants