Drop SOAP formatter and move to JSON based serialization #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikhinja
reviewed
Nov 21, 2023
| this.materialId = materialId.Value; | ||
| } | ||
|
|
||
| public DirectShapeState(SerializationInfo info, StreamingContext context) : |
Collaborator
There was a problem hiding this comment.
Won't this cause a breakage without obsolete message? Not that we need to keep this, but perhaps document somewhere for package developers?
Mikhinja
approved these changes
Nov 21, 2023
CustomBuildingConfigurators-Balaji
added a commit
to DynamoDS/DynamoPrimerNew
that referenced
this pull request
Nov 17, 2025
…zation based on the changes in the following PRs: 1. DynamoDS/Dynamo#14530 2. DynamoDS/DynamoRevit#3010 Changes made: Modified the code snippets Removed the warning message about not to rely on the serialized format of the data Modified the trace object serialization content. Added "Compatibility" section and the warning message displayed for legacy bindings.
QilongTang
pushed a commit
to DynamoDS/DynamoPrimerNew
that referenced
this pull request
Jan 8, 2026
…4530 / #3010 (#56) * Modified "Element Binding and Trace" section to to JSON based serialization based on the changes in the following PRs: 1. DynamoDS/Dynamo#14530 2. DynamoDS/DynamoRevit#3010 Changes made: Modified the code snippets Removed the warning message about not to rely on the serialized format of the data Modified the trace object serialization content. Added "Compatibility" section and the warning message displayed for legacy bindings. * Reverted the content changes for "TraceExampleItem" * Changes based on review from @mjkkirschner * Updated the typo for JSON * Corrected the spell error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This work is mostly done by @saintentropy - and uses the new JSON serialization based APIs for trace. This means strings are the new API type and serialization/deserialization to whatever format should be handled by the integrators as in this PR.
I have not been able to run these tests locally as RTF is out of date 😢 - but I did get this to at least build.
@Mikhinja let's please merge this ASAP and get a test run on so we can iterate on the failures we know will be here, I will help with that once I have a list of failures.
Also note that DynamoCore version is updated here to include the new APIs we need so that will also need to be updated on the Revit side.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@Mikhinja
FYIs
@saintentropy