Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Aug 11, 2019

Purpose

Attempted fix for JIRA: https://jira.autodesk.com/browse/DYN-2047. Fix loading of installed products that are in a non-root directory. Optimize product lookup using parallel, recursive search in all sub-directories.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @QilongTang

@mjkkirschner
Copy link
Member

mjkkirschner commented Aug 11, 2019

I guess to actually see if this works we need to merge this and test the complete install build? Since the self serve seems like it passes?

I'm wondering if it's not less risky to just add a flag to sandbox to select the exact path -for example does this have the potential to slow down Formit Dynamo startup time since they boot CLI or Sandbox everytime a user moves a slider - which will both do this preload step each time a run is requested...

@aparajit-pratap
Copy link
Contributor Author

We will soon find out. I've triggered another self-serve with the change of EnumerateFiles to compare with GetFiles. I think we should be good if the self-serve time to run tests does not change much from what it was before the inclusion of RSA.

@mjkkirschner
Copy link
Member

@aparajit-pratap okay - but I believe the self serve machine you are running against only has one copy of Revit installed - this means the search time will be potentially less than on other machines with multiple products - in any case hopefully this solution will still prove fast for products that have their dlls in the root.

@aparajit-pratap aparajit-pratap merged commit 1d186a5 into DynamoDS:master Aug 12, 2019
@aparajit-pratap aparajit-pratap deleted the fixLoadASM branch August 12, 2019 03:45
aparajit-pratap added a commit that referenced this pull request Aug 12, 2019
…all directories (#9904)

* Add support for loading ASM from RSA install location (#9884)

* support for loading ASM from RSA install location

* cleanup

* resolve cherry-pick conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants