Skip to content

Fix String From Array #9745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aparajit-pratap merged 3 commits into from
May 28, 2019
Merged

Fix String From Array #9745

aparajit-pratap merged 3 commits into from
May 28, 2019

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented May 28, 2019 •
edited
Loading

Purpose

Fixes issue reported: https://autodesk.slack.com/archives/C0W60575Z/p1558992887001100

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@reddyashish

FYIs

@mjkkirschner @QilongTang

@aparajit-pratap aparajit-pratap changed the title Fix String from array Fix String From Array May 28, 2019
mjkkirschner
mjkkirschner reviewed May 28, 2019
View reviewed changes
test/DynamoCoreTests/Nodes/StringTests.cs
string testFilePath = Path.Combine(localDynamoStringTestFolder, "TestStringFromArrayPreview.dyn");
RunModel(testFilePath);

AssertPreviewValue("c27d9e05-45f7-4aac-8f53-a9e485e0f9c0", "[1,2,3]");
Copy link
Member

@mjkkirschner mjkkirschner May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QilongTang
Copy link
Contributor

QilongTang commented May 28, 2019

LGTM. Thank you for the responsive fix! :shipit:

@aparajit-pratap aparajit-pratap merged commit 351c88b into DynamoDS:master May 28, 2019
@aparajit-pratap aparajit-pratap deleted the stringFromArray branch May 28, 2019 15:55
mjkkirschner pushed a commit that referenced this pull request Aug 3, 2019
@aparajit-pratap @mjkkirschner
Fix String From Array (#9745)
634c83f 
* fix string from array preview

* revert assemblysharedinfo

* more fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner mjkkirschner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aparajit-pratap @QilongTang @mjkkirschner