Skip to content

Conversation

@mjkkirschner
Copy link
Member

fixed formatting
fixed colors
fixed broken links

Purpose

@smangarole noticed there were some broken links and invisible colored text in the about box.

Declarations

I know this diff is hard to review ...
I have gone through and clicked every link to make sure they work - and updated some old ones that moved from codeplex to github.

Screen Shot 2019-03-26 at 8 42 35 PM

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@smangarole @alfarok @scottmitchell

FYIs

@kronz

fixed formatting
fixed colors
@mjkkirschner mjkkirschner added the PTAL Please Take A Look 👀 label Mar 27, 2019
@scottmitchell
Copy link
Collaborator

The SharpDX license link doesn't work for me.
https://github.com/sharpdx/SharpDX/blob/master/License.txt/

@scottmitchell
Copy link
Collaborator

Looks like it's changed to https://github.com/sharpdx/SharpDX/blob/master/LICENSE

@mjkkirschner
Copy link
Member Author

@scottmitchell thanks for catching it! will update it.

@scottmitchell
Copy link
Collaborator

Also take a look at the Microsoft Public License link. Somehow this is causing Dynamo to crash for me!?

@scottmitchell
Copy link
Collaborator

Besides those two links, everything else looks good.

@mjkkirschner mjkkirschner merged commit 695b59b into DynamoDS:master Mar 28, 2019
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Mar 28, 2019
* fixed broken links
fixed formatting
fixed colors

* fix broken links
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Mar 28, 2019
* fixed broken links
fixed formatting
fixed colors

* fix broken links
mjkkirschner added a commit that referenced this pull request Mar 28, 2019
* fixed broken links
fixed formatting
fixed colors

* fix broken links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PTAL Please Take A Look 👀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants